Optimize subset generation. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstdio
force-pushed
the
optimize-subset
branch
from
257b33f
to
e509c57
Compare
This commit provides significant performance boost for subset generation. Firstly, when assembling a next subset, namely instead of looping over original input and checking a subset state in the bit vector now we are loop directly on bit vector. The second one is that we don't unconditionally clear content of internal list, but overwrite old elements and clear leftovers afterwards.
nstdio
force-pushed
the
optimize-subset
branch
from
e509c57
to
5702661
Compare
|
Thank you for improving the performance of the subset iterator! |
|
Can we have a new patch version to try it out? |
|
Yes, the change is available in version 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides significant performance boost for subset generation. Firstly, when assembling a next subset, namely instead of
looping over original input and checking a subset state in the bit vector now we
are loop directly on bit vector. The second one is that we don't unconditionally clear content of internal list, but overwrite old elements and clear leftovers afterwards.