Fix pretty bad SQL bug

Was I drinking when I wrote those?
dpavlin · Oct 15, 2011 · 3f427ae · 3f427ae
1 parent 2d9f0b6
commit 3f427ae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/Act/AuthMethod/Facebook.pm b/lib/Act/AuthMethod/Facebook.pm
@@ -72,7 +72,8 @@ sub handle_postback {
     my $sth     = $dbh->prepare(<<SQL);
 SELECT u.user_id FROM facebook_auths AS fa
 INNER JOIN users AS u
-ON fa.facebook_id = ?
+ON fa.user_id = u.user_id
+WHERE fa.facebook_id = ?
 SQL
 
     $req->session->{'auth_method_info'} = $profile;

diff --git a/lib/Act/AuthMethod/Twitter.pm b/lib/Act/AuthMethod/Twitter.pm
@@ -85,7 +85,8 @@ sub handle_postback {
     my $sth = $dbh->prepare(<<SQL);
 SELECT u.user_id FROM twitter_auths AS ta
 INNER JOIN users AS u
-ON ta.twitter_id = ?
+ON ta.user_id = u.user_id
+WHERE ta.twitter_id = ?
 SQL
 
     $session->{'auth_method_info'} = {