Skip to content

Commit

Permalink
SDPAP-7121 - SDPAP-6835 - Removal of "Campaign with video" functional…
Browse files Browse the repository at this point in the history
…ity from secondary campaign banner (#1273)
  • Loading branch information
jeffdowdle committed Feb 28, 2023
1 parent 5fbaa54 commit 4e5465e
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,25 +37,4 @@ export const Template = (args, { argTypes }) => ({
</Story>
</Canvas>

export const TemplateWVideo = (args, { argTypes }) => ({
props: Object.keys(argTypes),
components: { RplCampaignSecondary },
template: '<rpl-campaign-secondary :title="title" :summary="summary" :link="link" :image="image" :video="video" />'
});

<Canvas>
<Story
name="With video"
args={{
title: 'Secondary campaign with video',
summary: 'Lorem ipsum dolor sit amet, <a href="#">consectetur</a> adipiscing elit, sed do eiusmod temporar incident incididunt ut labore et dolore magna aliqua. Ut enim ad minim niam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo.',
link: { text: 'Call to action', url: '#' },
image: null,
video: { src: 'https://www.youtube.com/embed/bSlnfyGTiss', mediaLink: { text: 'View transcript', url: '#' } }
}}
>
{TemplateWVideo.bind({})}
</Story>
</Canvas>

<ArgsTable of={RplCampaignSecondary} />
8 changes: 2 additions & 6 deletions packages/components/Organisms/CampaignSecondary/index.vue
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
<template>
<div class="rpl-campaign-secondary">
<div class="rpl-campaign-secondary__row">
<div v-if="image || video" class="rpl-campaign-secondary__left">
<div v-if="image" class="rpl-campaign-secondary__left">
<div class="rpl-campaign-secondary__content">
<rpl-responsive-img v-if="image" class="rpl-campaign-secondary__image" v-bind="image" alt="" />
<rpl-embedded-video v-if="!image && video" :variant="video.mediaLink ? 'link' : false" :src="video.src" :media-link="video.mediaLink" class="rpl-campaign-secondary__video" />
<rpl-responsive-img class="rpl-campaign-secondary__image" v-bind="image" alt="" />
</div>
</div>
<div class="rpl-campaign-secondary__right">
Expand All @@ -21,7 +20,6 @@
<script>
import breakpoint from '@dpc-sdp/ripple-global/mixins/breakpoint'
import RplButton from '@dpc-sdp/ripple-button'
import RplEmbeddedVideo from '@dpc-sdp/ripple-embedded-video'
import RplResponsiveImg from '@dpc-sdp/ripple-responsive-img'
export default {
Expand All @@ -31,12 +29,10 @@ export default {
title: String,
summary: String,
link: Object,
video: Object,
image: Object
},
components: {
RplButton,
RplEmbeddedVideo,
RplResponsiveImg
}
}
Expand Down
4 changes: 0 additions & 4 deletions packages/ripple-nuxt-tide/lib/config/tide.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,6 @@ const tideConfig = {
'image': {
field: ['field_block_image', 'field_media_image'],
filters: ['cardImage']
},
video: {
field: 'field_block_embedded_video',
filters: ['embeddedVideo']
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ module.exports = {
'field_landing_page_hero_banner',
'field_landing_page_c_primary.field_block_image.field_media_image',
'field_landing_page_c_secondary.field_block_image.field_media_image',
'field_landing_page_c_secondary.field_block_embedded_video',
'field_landing_page_key_journeys',
'field_landing_page_contact.field_paragraph_phones',
'field_landing_page_contact.field_paragraph_social_media',
Expand Down
1 change: 0 additions & 1 deletion packages/ripple-nuxt-tide/modules/profile/tide.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module.exports = {
profile: [
'field_profile_category',
'field_landing_page_c_secondary.field_block_image.field_media_image',
'field_landing_page_c_secondary.field_block_embedded_video',
'field_landing_page_contact.field_paragraph_phones',
'field_landing_page_contact.field_paragraph_social_media'
]
Expand Down

0 comments on commit 4e5465e

Please sign in to comment.