Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the webforms conditional logic #594

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Update the webforms conditional logic #594

merged 1 commit into from
Nov 15, 2019

Conversation

febdao
Copy link

@febdao febdao commented Nov 12, 2019

Changed

  1. Added the webforms conditional logic:
∙ visible
∙ invisible
∙ enabled
∙ disabled

Screenshots

@febdao febdao mentioned this pull request Nov 12, 2019
Closed
@tim-yao tim-yao changed the base branch from develop to feature/SDPSUP-1118-webform-conditional-logic-improvement November 15, 2019 03:16
@tim-yao tim-yao merged this pull request into dpc-sdp:feature/SDPSUP-1118-webform-conditional-logic-improvement Nov 15, 2019
@tim-yao tim-yao mentioned this pull request Nov 19, 2019
Merged
tim-yao pushed a commit that referenced this pull request Nov 19, 2019
@febdao @tim-yao
Update the webform conditional logic (#594)
840b334
tim-yao added a commit that referenced this pull request Nov 20, 2019
@tim-yao
[SDPSUP-1118] [SDPA-3400]Update the webform conditional logic (#594) (#…
7129da2 
…600)

* Update the webform conditional logic (#594)

* Updated tests for webform conditional logic

* Updated mapping error handling and tests

* Updated log request message to have full url so it's clickable

* Minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-yao tim-yao tim-yao approved these changes

@dylankelly dylankelly Awaiting requested review from dylankelly

@kurtfoster kurtfoster Awaiting requested review from kurtfoster

Assignees

@febdao febdao

Labels
Ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@febdao @tim-yao @FleetAdmiralButter