-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: separate dsc into a library and a binary crate #6
Conversation
Marking as "ready for review" because from what I can tell, this is working as expected! But it may be in what you consider to be a rough state, happy to iterate on this as feedback is presented |
@EricCrosson All good, but I think underscores vs hypens are super confusing. Would putting the binary and library in the same crate (like e.g. here: https://github.com/crev-dev/cargo-crev/blob/e9b35a1d24a7b877bf20d19632e8ef9f04b210ac/cargo-crev/Cargo.toml#L17) work for you? |
The motivation for this change is so that I can import the engine of docker-source-checksum as a function in some other binary, without introducing changes to current docker-source-checksum users.
Agreed! There may still be a bit of that, but I followed the example you linked and the diff is much cleaner. Thanks for the pointer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some criticisms of this code (was requested privately by @EricCrosson).
Thanks for the input @ocornoc. I'd like to keep this PR as close to a lift-and-shift as possible, but I'm happy to circle back with these suggestions |
Co-authored-by: Grayson Burton <ocornoc@protonmail.com>
Co-authored-by: Grayson Burton <ocornoc@protonmail.com>
Co-authored-by: Grayson Burton <ocornoc@protonmail.com>
Co-authored-by: Grayson Burton <ocornoc@protonmail.com>
@EricCrosson Proposed changes looked good so I added them. Please ping me if you're OK with my landing as is. |
@dpc Looks good to me! Thank you |
The motivation for this change is so that I can import the engine of docker-source-checksum as a function in some other binary, without introducing changes to current docker-source-checksum users.