Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated fix for refs/heads/hpack_use_vector #1

Open
wants to merge 2 commits into
base: hpack_use_vector
Choose a base branch
from
Open

Automated fix for refs/heads/hpack_use_vector #1

wants to merge 2 commits into from

Commits on Apr 13, 2022

  1. Restructure HPackParserTable to not use an inline table, and use a st… 

    …d::vector for its ring buffer instead.

Before this change, it uses 6.2KiB by default, 2/3 of the size of grpc_chttp2_transport. https://screenshot.googleplex.com/6qdcybty2oCsGjG

After this change, it uses 120 bytes https://screenshot.googleplex.com/4xGWKmZZz68VE4F

This class uses up substantial amounts of memory, as it is allocated on a per-stream basis. This should reduce the size of grpc_chttp2_stream substantially

It should cause a significant memory reduction, as the HPack extension table should almost never be fully populated in terms of number of entries, especially since common headers already exist in a static table and entries are highly likely to take more memory than the absolute minimum.
    @dpcollins-google
    dpcollins-google committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    b8e8d74 View commit details
    Browse the repository at this point in the history

  2. Automated change: Fix sanity tests

    @dpcollins-google
    dpcollins-google committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    29f99b6 View commit details
    Browse the repository at this point in the history