Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contentloaded.js #3

Closed
wants to merge 1 commit into from
Closed

Conversation

shimscharf
Copy link

polling should only occur in ie6 - 8 as ie9+ should use modern addEventListener[DOMContentLoaded], despite still supporting createEventObject and doScroll

polling should only occur in ie6 - 8 as ie9+ should use modern addEventListener[DOMContentLoaded], despite still supporting createEventObject and doScroll
@dperini
Copy link
Owner

dperini commented Feb 14, 2014

shimsharf,

the suggested change is correct. I will add that the next time I
open/update the project.

Also when adding this I will probably remove the "createEventObject" since
it seems an unnecessary duplication of the same exclusion check.

Thank you for the contribution.

Diego Perini

On Tue, Feb 11, 2014 at 5:21 AM, shimscharf notifications@github.comwrote:

polling should only occur in ie6 - 8 as ie9+ should use modern
addEventListener[DOMContentLoaded], despite still supporting

createEventObject and doScroll

You can merge this Pull Request by running

git pull https://github.com/shimscharf/ContentLoaded patch-1

Or view, comment on, or merge it at:

#3
Commit Summary

  • Update contentloaded.js

File Changes

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com//pull/3
.

@dperini
Copy link
Owner

dperini commented Aug 23, 2014

I updated the source with the suggested fix for IE9+.

Thank you @shimsharf

@dperini dperini closed this Aug 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants