Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions to enforce code style #15

Closed
lacabra opened this issue Apr 23, 2021 · 7 comments
Closed

Add GitHub actions to enforce code style #15

lacabra opened this issue Apr 23, 2021 · 7 comments

Comments

@lacabra
Copy link
Collaborator

lacabra commented Apr 23, 2021

After having implemented #14, configure the CI through GitHub Actions to enforce the code style upon committing files to the repo.

@rachita19082
Copy link
Contributor

@lacabra I would like to work on this issue. Please assign it to me.

@DivyanshiSingh
Copy link

hey, @lacabra Is this issue open to work. I would like to work on it.

@rachita19082
Copy link
Contributor

Hi @DivyanshiSingh, even though this has not been assigned to me yet, I had started working on this issue. I will make a PR for this as soon as my previous pull request for adding and configuring the setup is merged.

@DivyanshiSingh
Copy link

I thought that everyone has to follow the guidelines: DPGAlliance/publicgoods-candidates#473

@rachita19082
Copy link
Contributor

@DivyanshiSingh Yes, I have followed all the guidelines. I claimed this issue only after I had finished working on the previous issue and the previous one has been approved as well.

@lacabra
Copy link
Collaborator Author

lacabra commented Apr 27, 2021

@rachita19082: while I appreciate your numerous contributions, I had not assigned this PR to you for a reason: to give the rest of participants a fair chance to contribute. Everyone else is waiting for PR to get assigned to them, so kindly play by the rules. Thank you.

Since the work is already done, this PR will no longer be assigned, and can be considered closed (though it will not be formally closed until the corresponding PR is merged, which is awaiting an unrelated dependency)

@rachita19082
Copy link
Contributor

rachita19082 commented Apr 27, 2021

@lacabra @DivyanshiSingh I apologize for not waiting for the PR to be assigned. I have understood, I will wait for it to be assigned before working on any further issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants