Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions to enforce Python code style #64

Closed
Tracked by #39
lacabra opened this issue Oct 15, 2021 · 7 comments · Fixed by #90
Closed
Tracked by #39

Add GitHub actions to enforce Python code style #64

lacabra opened this issue Oct 15, 2021 · 7 comments · Fixed by #90
Assignees
Labels
good first issue Good for newcomers

Comments

@lacabra
Copy link
Collaborator

lacabra commented Oct 15, 2021

After having implemented #63, configure the CI through GitHub Actions to enforce the code style upon committing files to the repo

The analogous in NodeJS would be something like this)

@lacabra lacabra added the good first issue Good for newcomers label Oct 15, 2021
@lacabra lacabra mentioned this issue Oct 15, 2021
12 tasks
@NayOoLwin5
Copy link
Contributor

Hi @lacabra, I am an outreachy applicant. I am aware that I am already late for the party. But happy to contribute anytime.
Can you assign this issue to me? Shall I wait till #63 is closed or send a PR for this already?

@lacabra
Copy link
Collaborator Author

lacabra commented Oct 19, 2021

Thanks @NayOoLwin5, the party is in full swing, you are not late :) I have assigned this to you, but this is highly dependent on #63. Curious to hear from you how you would tackle this without having #63 fixed ?

@NayOoLwin5
Copy link
Contributor

I didn't know Github Actions can be tested locally. I just found out it can be tested with act before commit/push. For that, I will also need #63 as you mentioned for testing/fixing locally. I am waiting for #63.

@lacabra
Copy link
Collaborator Author

lacabra commented Oct 21, 2021

@NayOoLwin5 since #63 has been closed via #75, you now have everything you need to work on this.

@Ashara-kosi
Copy link
Contributor

Hello @NayOoLwin5 ,

How is it going with this?...would you be needing assistance?

@Ashara-kosi
Copy link
Contributor

@lacabra can I work on this since @NayOoLwin5 have been absent?

@NayOoLwin5
Copy link
Contributor

NayOoLwin5 commented Oct 28, 2021

Hi @Ashara-kosi, first of all, sorry for the lack of response from my side. There was a sudden arrangement of travel for me. That's why could not fully participate in this Outreachy contribution period. Will bounce back in the next one for sure. Good luck to you guys.👍

i completed this task here #90. You can also review my work and suggest any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants