Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPGs location data is not standardized #726

Closed
edil-it-them opened this issue Sep 23, 2021 · 4 comments · Fixed by #737
Closed

DPGs location data is not standardized #726

edil-it-them opened this issue Sep 23, 2021 · 4 comments · Fixed by #737
Assignees

Comments

@edil-it-them
Copy link
Contributor

Location data in digitalpublicgoods folder is not standardized. So it's harder to analyze and visualize data because we need to clean it up every time we load data.
For example, in the DPG map visualization we need to edit a loader script every time there is a new DPG.
I found that in a submission form there is a country list which solve the problem with new submissions.

Work to do:

  1. Clean up all existing data in digitalpublicgoods folder
  2. Sync country names in DPG map visualization with country names in the submission form

You can find an object with current implementation of data cleaning in loader script in DPG map project.

@edil-it-them
Copy link
Contributor Author

@lacabra kindly confirm that this schema points to country names used in submission form.

@lacabra
Copy link
Contributor

lacabra commented Sep 23, 2021

@Rolikasi: Yes I confirm that the above schema is the one used in the submission form, which will be used to create new entries.

I hear your frustration with the lack of standardization of country names in existing entries, so I would very much welcome a script to standardize existing entries. Or you can use the output of the script you are currently running to submit changes to any of the existing entries in the candidates repo

@edil-it-them
Copy link
Contributor Author

Great, I can work on it 🚀

@lacabra
Copy link
Contributor

lacabra commented Sep 23, 2021

Just for context, the discrepancies may come from the earliest submissions that were manually coded, and were not part of the form. Or now that I think of it, there is a glitch with that part of the form that results in some instances of people sending us their own list that is thus not standardized; so if you want to isolate a script that normalizes country names, I can team up with you to work on embedding it on the CI (or of course, you can tackle it all 💪)

Cc: @nathanbaleeta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants