Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Map] Sync package with standartized country list #82

Merged
merged 3 commits into from
Oct 5, 2021
Merged

[Map] Sync package with standartized country list #82

merged 3 commits into from
Oct 5, 2021

Conversation

edil-it-them
Copy link
Contributor

@edil-it-them edil-it-them commented Oct 4, 2021 •
edited
Loading

This PR was created alongside with this one
Work done

  • Standardized existing country list
  • removed country cleaner script
  • fixed bug with build output. It turned out that after nextjs update one more error appeared on build.

Related to issue in publicgoods-candidates

I tested changes on my machine. It looks fine. Kindly confirm if it runs correctly @lacabra
cc: @nathanfletcher

@lacabra lacabra self-requested a review October 4, 2021 17:02
lacabra
lacabra suggested changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good other than that unused dependency. Can you take a look @Rolikasi? Then we can merge

packages/map/package.json Outdated Show resolved Hide resolved
@lacabra lacabra self-requested a review October 5, 2021 14:00
lacabra
lacabra approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

@lacabra lacabra merged commit 058d542 into main Oct 5, 2021
@lacabra lacabra deleted the standardize-countries branch October 5, 2021 14:01
@edil-it-them edil-it-them mentioned this pull request Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lacabra lacabra lacabra approved these changes

Assignees

@edil-it-them edil-it-them

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edil-it-them @lacabra