Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax SQLAlchemy version dependency #1710

Closed
vsolovyov opened this issue Oct 7, 2021 · 3 comments
Closed

Relax SQLAlchemy version dependency #1710

vsolovyov opened this issue Oct 7, 2021 · 3 comments

Comments

@vsolovyov
Copy link

Right now in setup.py we have SQLAlchemy pinned to <1.4.0:

    # SQLAlchemy 1.4.0 breaks flask-sqlalchemy and sqlalchemy-utils
    "SQLAlchemy<1.4.0",

flask-sqlalchemy added support for 1.4 in release 2.5.0 (released in March).
sqlalchemy-utils added support for 1.4 in release 0.37.0 (released in April).

I think we should update SQLAlchemy dependency.

@dpgaspar
Copy link
Owner

dpgaspar commented Oct 7, 2021

We can't there's still an issue on flask-sqlalchemy: pallets-eco/flask-sqlalchemy#1001
or wait for the next major release (3.0.0) where that issue is solved also

@kyoshi-warrior
Copy link

kyoshi-warrior commented Dec 2, 2021

Any update on easing this dependency?
# SQLAlchemy 1.4.0 breaks flask-sqlalchemy and sqlalchemy-utils "SQLAlchemy<1.4.0",
this is breaking as some of our other libraries require SQLAlchemy >= 1.4.0

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to reopen it if it's still relevant to you. Thank you

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants