Skip to content

Commit

Permalink
Bugfix formaction dict class update (#306)
Browse files Browse the repository at this point in the history
* Do not update a dictionary as a class property, as it will not update the instance, but the class itself

* update changelog
  • Loading branch information
Johnny Mijnhout authored and mmarcos committed Jul 20, 2018
1 parent 62a2bda commit ff3f3ff
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

Always reference the ticket number at the end of the issue description.

## Pending

### Fixed

- get_actions: formaction dictionary was updated directly as class attribute

## 1.3.1 (2018-07-03)

Expand Down
2 changes: 1 addition & 1 deletion arctic/mixins.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def get_actions(self): # noqa: C901
if action[2].get('style'):
allowed_action['custom_style'] = True
if action[2].get('form_action'):
action[2]['form_action'] = self.in_modal(
allowed_action['form_action'] = self.in_modal(
reverse_url(action[2]['form_action'], obj))
allowed_action.update(action[2])

Expand Down

0 comments on commit ff3f3ff

Please sign in to comment.