registered origin constraints with /info #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
min_ttl, max_ttl, default_ttl, and max_cdn_file_size are now exposed in the /info endpoint under the 'cdn_origin' key. In order to keep only one place for setting the default values in the code, the defaults for these variables is set in a constant. A functional test was added to check that these values exist and return something castable to an int. Updated the sample config to reflect the default value set by the code.
|
sorry- merged my other patch and now there's a conflict. other than that looks fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min_ttl, max_ttl, default_ttl, and max_cdn_file_size are now
exposed in the /info endpoint under the 'cdn_origin' key.
In order to keep only one place for setting the default values
in the code, the defaults for these variables is set in a constant.
A functional test was added to check that these values exist and
return something castable to an int.
Updated the sample config to reflect the default value set by the code.