Ensure the opened config file gets closed and that an HTTP(S) connection is made before RPC call #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoldenChrysus
changed the title
GoldenChrysus
changed the title
dpifke
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1
The _parse_config() function in bitcoind.py opens a file object but never closes it. If another program using pifkoin instantiates Bitcoind enough times, the system will eventually throw a "too many files open" error due to the constant opening without closing of files by pifkoin.
Issue 2
Making requests to the established HTTP(S)Connection several seconds apart (in this case, 60 seconds) causes BadStatusLine to be thrown because the connection is no longer established. Python documentation states that .connect() is called by default before every request, but this does not seem to be the case. Explicitly calling self._rpc_conn.connect() before the request in _rpc_call() resolves the issue.