Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IT Tests Cleanup Makes Dev Database Empty #368

Closed
DPigeon opened this issue Apr 3, 2021 · 0 comments · Fixed by #369
Closed

IT Tests Cleanup Makes Dev Database Empty #368

DPigeon opened this issue Apr 3, 2021 · 0 comments · Fixed by #369
Assignees
@DPigeon
Labels
backend Tasks that require backend work bug Something isn't working
Milestone
[Release 3] Sprint 9

Comments

@DPigeon
Copy link
Owner

DPigeon commented Apr 3, 2021

Describe the bug
When the integration tests are running locally or on the CI, some tests "deleteAll" entity persisted in the entire database.

To Reproduce
Steps to reproduce the behavior:

  1. Create a user on dev.money-tree.tech
  2. Run all backend tests
  3. Look at the dev database
  4. The user you created is also deleted because of the cleanup

Expected behavior
It should only delete needed users used in tests and not a user created on the frontend

Desktop (please complete the following information):

  • CI Pipeline

Smartphone (please complete the following information):

  • Linux

Additional context
This needs to be fixed ASAP to test on the DEV environment properly while others create PRs (making the CI pipeline run and deleting all entities on the dev db).

Bug reported by @DPigeon
@DPigeon DPigeon added bug Something isn't working backend Tasks that require backend work labels Apr 3, 2021
@DPigeon DPigeon added this to the [Release 3] Sprint 9 milestone Apr 3, 2021
@DPigeon DPigeon self-assigned this Apr 3, 2021
DPigeon pushed a commit that referenced this issue Apr 3, 2021
#368: Fix the transaction IT tests cleaning database
f73a311
@DPigeon DPigeon mentioned this issue Apr 3, 2021
Merged
1 task
@DPigeon DPigeon linked a pull request Apr 3, 2021 that will close this issue
#368: Fix IT Tests Cleanup for Dev Database #369
Merged
1 task
DPigeon added a commit that referenced this issue Apr 3, 2021
@DPigeon
Merge pull request #369 from DPigeon/bug/#368-fix-tests-cleanup-database
419bb06 
#368: Fix IT Tests Cleanup for Dev Database
@DPigeon DPigeon closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DPigeon DPigeon

Labels
backend Tasks that require backend work bug Something isn't working
Projects
None yet
Milestone
[Release 3] Sprint 9
Development

Successfully merging a pull request may close this issue.

#368: Fix IT Tests Cleanup for Dev Database DPigeon/Money-Tree
1 participant
@DPigeon