Remove reference to additional_target_cpus #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter will be removed from Chromium build system. While this is just a meaningless key in a sample json file used for performance testing, the project is cloned into Chromium and the string "additional_target_cpus" shows up when doing search in the codebase of Chromium. Removing the line from the sample should change too much the validity of the performance testing, but it would simplify the effort of removing the additional_target_cpus parameter from Chromium build system as this would remove false positive when searching the codebase. Reference: https://crbug.com/1337780
|
Looks good. Thanks for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter will be removed from Chromium build system. While this is just a meaningless key in a sample json file used for performance testing, the project is cloned into Chromium and the string "additional_target_cpus" shows up when doing search in the codebase of Chromium.
Removing the line from the sample should change too much the validity of the performance testing, but it would simplify the effort of removing the additional_target_cpus parameter from Chromium build system as this would remove false positive when searching the codebase.
Reference: https://crbug.com/1337780