Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use more iterator and named format args #1

Merged
merged 8 commits into from
Nov 27, 2023
Merged

refactor: use more iterator and named format args #1

merged 8 commits into from
Nov 27, 2023

Conversation

scarf005
Copy link
Contributor

  • refactor: destructure range
  • style: clippy
  • refactor: extract options
  • refactor: collect text_changes immutably
  • refactor: inline format arguments

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

dsherret
dsherret requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I'd rather keep the code mostly the way it is. The iterator change is good though.

src/format_text.rs Outdated Show resolved Hide resolved
src/format_text.rs Outdated Show resolved Hide resolved
src/text_changes.rs Outdated Show resolved Hide resolved
dsherret
dsherret approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret merged commit c842992 into dprint:main Nov 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scarf005 @CLAassistant @dsherret