Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .json extension instead of .exe-plugin #521

Closed
dsherret opened this issue Apr 23, 2022 · 1 comment
Closed

Use .json extension instead of .exe-plugin #521

dsherret opened this issue Apr 23, 2022 · 1 comment
Labels
breaking change Change that breaks something enhancement New feature or request

Comments

@dsherret
Copy link
Member

dsherret commented Apr 23, 2022

Process plugins currently use the file extension .exe-plugin. I initially went with this decision to emphasize the fact that an executable will be downloaded and executed. Few reasons I would like to change this to use a .json extension instead:

  1. I really don't like this custom extension
  2. People are forced to provide a checksum anyway
  3. The .json extension helps clue to people that this is some manifest file that they can look at.
  4. Using the .json extension instead will open the door to using the .json extension for more than just process plugins. Perhaps in the future there could be pre-compiled Wasm plugins that use a json file as well (ex. precompile with llvm, which would be faster) or support for Wasm plugins that need assets in addition to a .wasm file (though, perhaps a zip file could server better).
@dsherret dsherret added enhancement New feature or request breaking change Change that breaks something labels Apr 23, 2022
@dsherret
Copy link
Member Author

Implemented in 489fb79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Change that breaks something enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant