perf(npm): use direct binary for startup boost #839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This comment was marked as outdated.
This comment was marked as outdated.
dalisoft
changed the title
dsherret
reviewed
Apr 14, 2024
| "scripts": { | ||
| "postinstall": "node ./install.js", | ||
| "postinstall": "node ./postinstall.js", |
There was a problem hiding this comment.
I think this now requires the post install step? Previously dprint would work even when someone did npm install --ignore-scripts.
There was a problem hiding this comment.
Yes, it is true. This is cost for performance improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes/PR should improve startup performance of CLI by up to 5 times and very huge impact for
lint-staged,pre-commitandpre-pushcommitsThis PR conflicts with #840 as this PR uses different approach to use binary
Use this or #840
Approve and merge whichever ways you want/like
Added support for arm64 on npm
build.ts