feat: association option don't overwrite plugin supports
#842
Conversation
|
|
| file_exts.extend(&plugin.file_matching.file_extensions); | ||
| } | ||
| file_names.extend(&plugin.file_matching.file_names); | ||
| file_exts.extend(&plugin.file_matching.file_extensions); |
There was a problem hiding this comment.
What extension do you need for the prettier plugin that it currently doesn't support? I'm not sure about this change because it will certainly break someone.
There was a problem hiding this comment.
Tencent's miniprogram has a .wxml extension file, which is similar to HTML. In Prettier, i can configure its parser through overrides. prettier/prettier#9081 (comment)
This change could indeed have unexpected impacts on existing configurations. A better approach would be to modify the Prettier plugin to support returning the configured *.parser association.
Currently, I support it by manually configuring all the files that need to be formatted using Prettier, so I will close this.
fixed: #841