Attempt at making TreeNode more flexible #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an attempt at making it even more flexible, EG usable with thread IDs.
Main difference is that TreeNode no longer has inclusive / exclusive numeric fields. Instead it will store whatever object you need to store, like a group of thread IDs. Then you can use the optional
get_inclusive_value
function get an inclusive view of whatever data you have in there. It's a little less performant because it's not precomputed but it's no big hassle since this is computed after the report generation stage.See this "test" I added:
Here is the sorted output: