Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model documentation simon #1

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Model documentation simon #1

merged 3 commits into from
Dec 2, 2021

Conversation

edmondchuc
Copy link

@edmondchuc edmondchuc commented Dec 2, 2021

@dr-shorthair I've made some updates to address your PR in ternaustralia#13.

Sites, site visits, samplings and observations can use the TERN Location Alignment vocabulary, which is a minimal ontology to tie together the GeoSPARQL vocabulary and the W3C Basic Geo WGS84 vocabulary.
TERN Location Alignment also defines a specialised Point class with properties to express the depth and elevation.
LineString and Polygon are also specialised to denote that a WKT literal is required.
Sites, site visits, samplings and observations can use the TERN Location Alignment vocabulary, which is a minimal ontology to tie together the GeoSPARQL vocabulary and the W3C Basic Geo WGS84 vocabulary. See https://w3id.org/tern/ontologies/loc.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My general recommendation is to use GeoSPARQL and WKT as much as possible. LOC gives the alternative of addresses or locations denoted by some text string, but in practice I think we will usually have coordinate-based geometries?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOC gives the alternative of addresses or locations denoted by some text string

tern-loc:Point basically defines a few constraints to require wgs:lat, wgs:long and geosparql:asWKT.

Not sure if we are looking at the same thing. I don't see any references to addresses or locations denoted by text string.

These are the current geometries defined in tern-loc for use with the TERN Ontology.

but in practice I think we will usually have coordinate-based geometries?

Currently the 3 geometries defined in tern-loc all require a wktLiteral to represent the geometry.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was incorrect. I had not looked property at tern-loc - I had conflated it with https://www.w3.org/ns/locn

Copy link
Owner

@dr-shorthair dr-shorthair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments below. 'fiat' needs to stay as is. The comment about geometry representations does not affect this documentation at this time, but is food-for-thought later on.

@edmondchuc
Copy link
Author

Thanks @dr-shorthair, I've resolved the comment relating to fiat and I've left a reply to the other comment.

@dr-shorthair dr-shorthair merged commit bbbdec3 into dr-shorthair:model-documentation-simon Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants