Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host: possibility to change seating #23

Closed
tooomm opened this issue May 20, 2017 · 1 comment · Fixed by #84
Closed

host: possibility to change seating #23

tooomm opened this issue May 20, 2017 · 1 comment · Fixed by #84

Comments

@tooomm
Copy link
Contributor

tooomm commented May 20, 2017

A host should be able to swap the position of players before the draft starts (with little arrows for example).
This would allow for easier team drafts which have a fixed seating.
Also, when an external site/service requires a specific player order for example or there is any other reason you want to influence things (redo a draft with same order...) it would be nice to be more flexible.

HerveH44 added a commit to HerveH44/dr4ft that referenced this issue Aug 12, 2017
HerveH44 added a commit to HerveH44/dr4ft that referenced this issue Aug 12, 2017
dev-id added a commit that referenced this issue Jan 2, 2018
Dev: Add possibility to change seating (#23) and possibility to shuffle
@tooomm
Copy link
Contributor Author

tooomm commented Jan 3, 2018

#33 adds initial support for this 👍

Some issues still stand with that implementation:

  1. What I miss there is, that once a host start swapping people around with the arrow buttons, shuffle should get automatically checked and disabled to make sure his preferred seating order isn't mixed up again!

  2. Regarding the swapping buttons itself:
    Since you can't cycle a player on position 1 to the bottom if you hit up, It would be clearer to disable/grey out up for the first player, and down for the last.
    You can hit those buttons but just nothing happens currently.

I think we also talked in gitter chat about the last one and said that cycling players from 1 "up" to 8 would also be very nice. So it's either of those: Allow cycling or disable up/down buttons on first/last position. I prefer cycling since it's more intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant