Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin abstracting pool source #1543

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Begin abstracting pool source #1543

wants to merge 5 commits into from

Commits on Jul 18, 2021

  1. Fix can get data directory test for Windows 

    One of the unit tests was assuming a forward slash seperator,
even though the implementation uses path.join(). This meant the
test would fail on Windows platforms because on Windows path.join()
would use a back slash path seperator.

Type: Bug Fix
    @psettle
    psettle committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    c74718f View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Wrap pool related data in new poolBuilder class 

    Add a new class that wraps data related to what cards and how many cards
will be needed for a game.

Type: Code Improvement
    @psettle
    psettle committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    094a20c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dr4fters:master' into master

    @psettle
    psettle committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    8059dd9 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. Fix eslint errors

    @psettle
    psettle committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    cb95df9 View commit details
    Browse the repository at this point in the history

  2. Fix unit tests after recent refactor

    @psettle
    psettle committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    e178394 View commit details
    Browse the repository at this point in the history