Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to set card's size (to decrease loading image time) #343

Merged
merged 4 commits into from
Feb 22, 2019
Merged

Allow user to set card's size (to decrease loading image time) #343

merged 4 commits into from
Feb 22, 2019

Conversation

HerveH44
Copy link
Contributor

@HerveH44 HerveH44 commented Feb 22, 2019 •
edited
Loading

Closes #329

image

@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-343 February 22, 2019 14:32 Inactive
@HerveH44 HerveH44 mentioned this pull request Feb 22, 2019
Closed
@tooomm
Copy link
Contributor

tooomm commented Feb 22, 2019 •
edited
Loading

Not so sure about Set cards image.
What about Card image quality?

Default seems to be small, I would rather have it on normal as the bad quality is not readable.
I like that it refreshes all pics right after changing the setting.

Is this supposed to be a fix for #329?

@HerveH44
Copy link
Contributor Author

@tooomm I pushed your propositions. And yes, it should closes #329

tooomm
tooomm approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@tooomm tooomm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked heroku, and it's nice. :)

Thanks for the updates.

@ZeldaZach ZeldaZach merged commit c3ce7f9 into master Feb 22, 2019
@ZeldaZach ZeldaZach deleted the card_image_size branch February 22, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tooomm tooomm tooomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HerveH44 @tooomm @ZeldaZach