Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify with toast a message when player has chatbox closed #345

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

HerveH44
Copy link
Contributor

@HerveH44 HerveH44 commented Feb 22, 2019

Fix #53

peek 2019-02-22 16-39

@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-345 February 22, 2019 15:35 Inactive
@ZeldaZach
Copy link
Member

We can also use a browser or OS built in notification system. See Facebook for example. This could be a fallback if they don’t want system notifications.

@HerveH44
Copy link
Contributor Author

Well browsers' notifications are when you don't look at the browser at all right? It seems a bit overkill for me to do so. Also you would receive a notification even when you're looking at the draft? That would be even weirder!

@ZeldaZach
Copy link
Member

Fair enough, this is cool!

@ZeldaZach ZeldaZach merged commit 2bc20cd into master Feb 22, 2019
@tooomm tooomm deleted the notify_hidden_chat branch February 24, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants