Refactor pool generation #349
Conversation
|
It throws an error for me when starting a game: (room creation works) No matter which combination of settings (modern only, total chaos) I choose. |
|
@tooomm can you try with the last build? I understood that heroku didn't use the last version of NodeJS! |
|
No error now! :) |
|
Playing sealed, but it's still in draft-like mode? It also shifts my position in the draft every time the timer expires and adds more cards to my draft pool.
Trying to start a triple RNA draft doesn't work... and now your heroku instance died :P |
|
Overall, this is a great change and can't wait to get it added! Some concerns: I don't see cubeHash used anywhere. No way to see the has you generate. Also, please use something other than MD5, like sha512. When trying to cube draft, on the last pack, the last pick glitchs out and leaves a state where you're missing a card and have this: (Note the card is never added to your pool. I did an 8x3 and ended up with 24 cards here. |
This one is a big baby. I rewrote the part where the server creates the pool (packs of cards) to have a specific entry for every type of game we handle.
I haven't touched at the packs creation in se (with all the specific rules depending of the set), just clarified how we create a cube pool, normal pool or chaos pool.
Closes #68
I added the mode chaos sealed. It takes the same parameters as chaos draft.
Closes #25
I then pushed a little bit to introduce "cubePoolSize" a new variable to adjust the number of cards a cube player can have in his sealed.
Closes #27
In the end I also added the cube hash requested by @dev-id to the draft cap. I used md5, is it
Closes #350
I also cleaned up a bit code when I saw there was something old (readyToStart feature parts for example)