Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset cubes dropdown #384

Merged
merged 9 commits into from
Mar 6, 2019
Merged

Preset cubes dropdown #384

merged 9 commits into from
Mar 6, 2019

Conversation

benjaminpwagner
Copy link
Contributor

@benjaminpwagner benjaminpwagner commented Mar 6, 2019

Adds a dropdown next to the cube list textarea. Fills textarea upon selection (Using global App.state)

Also added axios and babel-polyfill - updated webpack config to allow for async/await usage on the client side.

Fixes #3

update: fixes clean-webpack-plugin error with v2

@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-384 March 6, 2019 02:22 Inactive
@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-384 March 6, 2019 02:34 Inactive
@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-384 March 6, 2019 02:36 Inactive
@HerveH44 HerveH44 temporarily deployed to beta-dr4ft-pr-384 March 6, 2019 03:03 Inactive
weird interaction between optgroup and clean-webpack-plugin causes page to lose styling after refresh
@HerveH44
Copy link
Contributor

HerveH44 commented Mar 6, 2019

Hey, that seems awesome. Though I have couple questions:

  • why axios and not use builtin "fetch" ?
  • why remove webpack clean plugin ? You don't think it's safer to delete all previous builds before making a new one?
    -The preset cubes selects/options maybe could have been a "Select" component? I feel that you have all the informations to create our custom Select, it's easier to read I think (under public/src/utils.jsx)
  • Could we sanitize the elements we send back from the "cubes" API? I know it sounds silly but I just read about this kind of things...
  • What is the use of babel/polyfill?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create preset cubes
3 participants