Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

Hides troubleshooter link if codes are not equal #11

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Hides troubleshooter link if codes are not equal #11

merged 1 commit into from
Nov 3, 2023

Conversation

Shadowtail117
Copy link
Contributor

This PR will hide the troubleshooter link below the codes if the codes are not equal. This is because if they are not equal (meaning the adblocker hasn't been updated), the user should expect the popup, and there isn't a need to troubleshoot why they are still seeing it. It is only shown when the codes are the same, as if the user still sees a popup in that case, they should start troubleshooting using the guides on Reddit.

Also adds missing semicolons in the two main blocks of areCodesEqual() for consistency.

@drHyperion451
Copy link
Owner

I agree with you about removing the troubleshoot footer when the user says no. I'm planning on adding another icon in the menu website that will href to the subreddit though.

@drHyperion451 drHyperion451 merged commit 3d61b5a into drHyperion451:dev Nov 3, 2023
@Shadowtail117 Shadowtail117 deleted the troubleshoot branch November 4, 2023 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants