This repository has been archived by the owner on Apr 14, 2024. It is now read-only.
Add dynamic forceEquality updates #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot. This is very good. Is there a reason why the forceEquality is structured like a .ini file? It's just a dumb quuestioon but the file could be just 1 or 0 instead of |
|
Oh it was because originally I had this checking the main.js file originally, but I realized afterwards the implication of that: It would update the JS file as well and...defeat the purpose of this change. So I just copied and pasted the exact line and forgot to change it. I can make an update to this PR to fix that quickly if you'd like. |
|
It's not necessary, moreover, I could reuse the file to create more options if needed in the future. Thanks! |
|
No problem! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check for forceEquality on the deploy branch so it does not require a cache refresh or a rebuild on Pages in order to change it.
* I originally thought the page itself automatically updated without refreshing.