Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

Button propperly added #31

Merged
merged 7 commits into from
Nov 10, 2023
Merged

Button propperly added #31

merged 7 commits into from
Nov 10, 2023

Conversation

drHyperion451
Copy link
Owner

@u-RraaLL Please review this change. Also I can't make it more easy because my subdomain is not whitelisted. See the issue #30 for more info.

@u-RraaLL
Copy link
Collaborator

forceOption = 'yes'

Doesn't that make the website always say yes, without checking?

@drHyperion451
Copy link
Owner Author

drHyperion451 commented Nov 10, 2023

forceOption = 'yes'

Doesn't that make the website always say yes, without checking?

Yes, before merging i will delete this

@u-RraaLL
Copy link
Collaborator

Ok, give us some time to discuss how we want to implement this. At the very least, I'd like to put some instructions similar to what I've done in the pinned thread earlier.

@u-RraaLL
Copy link
Collaborator

Okay, I see two resolutions to this:

  1. I make a dedicated wiki page on reddit with instructions to updating the list via a link and we link to that.
  2. I add the instructions here, but we'd need to button to change links based on the age of the solution.

While I wasn't told this directly, I think the chances for this project moving under uBO or it being "whitelisted" for updates are very slim.

So what do you think about these two options?

@drHyperion451
Copy link
Owner Author

drHyperion451 commented Nov 10, 2023

2. I add the instructions here, but we'd need to button to change links based on the age of the solution.

Not only this is pretty good to user experience but coincidentally I've created a function for the "updated since" that can be perfectly used on this solution. I like this.

@drHyperion451 drHyperion451 added enhancement New feature or request js Issue reegarding JavaScript labels Nov 10, 2023
@u-RraaLL
Copy link
Collaborator

I added the instructions. Please make the button behave this way:

  1. The latest fix is under 10 minutes old - no button.
  2. 10 minutes to 6 hours - the longer link.
  3. Over 6 hours, the shorter link.

Once that's done we can probably go live with this.

@drHyperion451
Copy link
Owner Author

drHyperion451 commented Nov 10, 2023

Had a problem with diverging branches. I'm adding your requests.

Working on this url: https://super-barnacle-jj5x69vr9wxx2pr7-8080.app.github.dev/

Copy link
Collaborator

@u-RraaLL u-RraaLL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@drHyperion451
Copy link
Owner Author

Done. Got ip blocked for an hour trying but I think this is it. Check it out @u-RraaLL

@drHyperion451 drHyperion451 merged commit 08d0653 into dev Nov 10, 2023
@drHyperion451 drHyperion451 deleted the 30-update-quickfix-button branch November 10, 2023 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request js Issue reegarding JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an auto-update quick fix filters button to the website.
2 participants