-
Notifications
You must be signed in to change notification settings - Fork 34
Button hiding & behaviour + some tweaks #42
Conversation
I mean: start checking the release time of the YT script. Display it only when the latest script (new ID) isn't solved yet. Instead of displaying |
The problem is I can't do this. Pastely API doesn't let me know the last time the script was modified. So either we ask stephenhawk8054 to move the script from pastely or we cant do this :( |
Btw, here is the pastefy api for the youtube script: https://pastefy.app/api/v2/paste/G1Txv5su |
Right, I forgot to check. I've left him a message. I'll let you know what he replies. If it's a no-go, then maybe hide the |
I don't know. I don't even know any other good alternative for pastefy that it's free, API is free and has a "modified time" info avaliable in their api. Also I think it's a good idea to hiide the last tiime updated when it doesn't match because there iis no point of doing do plus sometimes uBlock still works even if they don't match. The >14h hiding option i think it's not good though since it's informative to the user, but I let you guys decide on thiis or open a Poll |
Are you talking about the button or update time? Or do you mean to not hide the text along the button? In which case we could replace the button with some info like |
i'm talking about the update since time display that appears at the bottom of the banner.
That's a good idea actually. |
Well, I said 24hrs. But I guess we can probably just stick to no time when IDs mismatch. |
His reply:
|
This is perfect. He can start right now using this format (it's compatible with my current script) |
modules/are_codes_equal.mjs
Outdated
|
||
// Date | ||
//let dateYoutubeId = new Date(infoParts[1]) | ||
let dateYoutubeId = new Date('2023-11-27 05:27+00:00') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main get logic is already implemented. There is a placeholder inside this comment that will be deleted to avoid errors for now until stephenhawk8054 updates the pastefy. A web designer will be good in this situations to decide where to put this info now.
This last commit fixes #40 @u-RraaLL Sorry for bothering you but this is going to be merged very soon. I want to make sure I have all things clear. Now it can fetch the youtube date as well as the ublock date. What should we do with this info? What date should be displayed and when exactly? Also @stephenhawk8054 thanks for updating the pastefy. |
If IDs match, display If IDs don't match, display |
This was sugested by @u-RraaLL inside #41 . But was moved here for convenient reasons.
Discussions should be placed here.