Language Bar + Polish,French language #51
Conversation
Added some simple Language bar + polish translation of a website.
Merged french translation from @jojoblackFr's pull request ( #50 ) to Language Bar Co-Authored-By: jojoblackFr <57195692+jojoblackfr@users.noreply.github.com>
kvbaxi
changed the title
|
Merged french translation from #50 to this pull request. |
|
Thanks. I'm reviewing the PR and running it in Safari works perfectly and I love it. However in Firefox 121 in MacOS doesn't show anything at all. I'm gonna try fix it myself but anything could help as well. |
drHyperion451
added
enhancement
|
Also I need to make the globe symbol dark theme friendly, but it's not priority |
|
gonna check with firefox then |
Found the issue. Incrementing the boottom position of the menubar reveals the menubar is overflow and shows the globe very far down. Looking for the answer. Maybe it's related to the languages not being absolute/out of the flexbox? |
Yeah... It's the languages div who is causing the problem in firefox. Damn you Mozilla!! 😂
|
|
Setting the position of the #languages to fixed/absolute "fixes" the problem but it's not properly placed and the globe is behind the language button, so still no clear improvements. Maybe adding a pointers-event to none fixes it, and also fixes another small issue with safari of still being able to click on the languages while being hidden |
|
Opera got the same problem and language button is clickable without being seen yeah same issue for the clickable |
|
Found a quick solution to the position. I'm gonna try merge it and please test it |
|
yeah everything got the placement issue, got it with chrome |
Lets see if this works
|
Tell me if it works now. I'm gonna fix the clickable issue as well |
|
work on Opera, Firefox and Chrome |
|
Check this out |
|
Opera + Firefox + Chrome passed flawlessly |
|
gonna change logo color first |
|
|
|
Don't worry. It's just a mistake inside the css. Im gona push the changes |
|
Check it out. If it works then I will merge soon |
|
Btw, how can I directly push from local changes to this pr? I've been doing this all inside github.com, but my workspace is local. Already tried something like git fetch origin pull/51/head:lang_bar
git switch lang_bar
git add *; git commit -m "commit name"
git push origin lang_barHowever, this creates a new lang_bar branch. How can I push to this speciffic pull request lol? |
|
idk i can't push to this pr at all |
|
Possible to put it lighter ? Like the gray of Reddit's icon after this, everything looks good on my side |
|
Maybe when I merge the branch I will do it |
Added some simple Language bar + polish translation of a website.