Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applies clang format #96

Merged
merged 2 commits into from Sep 22, 2021
Merged

Applies clang format #96

merged 2 commits into from Sep 22, 2021

Conversation

abaire
Copy link
Contributor

@abaire abaire commented Sep 21, 2021

Applies the .clang-format file added in #95

@abaire
Copy link
Contributor Author

abaire commented Sep 21, 2021

I tried to minimize changes, but using clang-format 10.0 has some rougher grained options that lead to a few compromises (e.g., never allowing {} on a single line because it'll also do that in places that end up looking unusual, in my opinion)

Note: I chose 10.0 as the lowest common denominator because it's the version easily available on WSL2. I had initially used 12.0.1 on macOS and it looks like Debian/Ubuntu have 12.x in the latest releases as well.

@abaire abaire marked this pull request as draft September 21, 2021 16:34
@dracc
Copy link
Owner

dracc commented Sep 22, 2021

This was an eye opener, for sure. I write ugly code! 😂

Thanks! 👍

@dracc dracc marked this pull request as ready for review September 22, 2021 18:30
@dracc dracc merged commit 568c772 into dracc:master Sep 22, 2021
@abaire abaire deleted the applies_clang_format branch September 22, 2021 18:32
@abaire
Copy link
Contributor Author

abaire commented Sep 22, 2021

:) Without automated style enforcement I think inconsistencies slip through no matter how careful we are. I'll send you a followup w/ a pre-commit hook to run the formatter as well and will look into a git workflow to check it server-side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants