Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Workflow for automatic builds of Docker images #168

Closed
ingoboerner opened this issue Jul 27, 2022 · 7 comments
Closed

Implement Workflow for automatic builds of Docker images #168

ingoboerner opened this issue Jul 27, 2022 · 7 comments
Milestone

Comments

@ingoboerner
Copy link
Collaborator

After a new release is created a github action could build a docker image and push it to container registries, e.g. Docker-Hub and Github Packages: https://docs.github.com/en/actions/publishing-packages/publishing-docker-images#publishing-images-to-docker-hub-and-github-packages

@ingoboerner
Copy link
Collaborator Author

I had to change the above mentioned action to make it work for a local frontend:
https://github.com/ingoboerner/dracor-frontend/blob/main/.github/workflows/publish_image_to_dockerhub.yml#L40-L41

@ingoboerner
Copy link
Collaborator Author

also this should go into the action for building the api:
https://github.com/ingoboerner/dracor-api/blob/main/.github/workflows/publish_image_to_dockerhub.yml#L41-L42 otherwise there is no connection to the metrics service

@ingoboerner
Copy link
Collaborator Author

We have an "official" account now: https://hub.docker.com/u/dracor I created the repositories for api, metrics, frontend, fuseki. I tested it and pushed a local build of dracor-api https://hub.docker.com/u/dracor

@ingoboerner
Copy link
Collaborator Author

I added the workflow but it will run only on next release: https://github.com/dracor-org/dracor-api/blob/main/.github/workflows/publish_docker_image_dockerhub.yml @cmil sorry, I created the action on the web interface and did't see that this is done directly on the main branch.
I can not test the action manually, maybe you could check, when you release the next version? In the worst case the action will fail.

@ingoboerner
Copy link
Collaborator Author

currently, I think the build is only based on the Dockerfile. Maybe we would have to use a github action that builds based on docker compose because of stuff like #200
e.g. https://github.com/peter-evans/docker-compose-actions-workflow

@cmil
Copy link
Member

cmil commented Dec 11, 2023

We now have automated multi-platform builds on release for all of our services (except for the frontend, where there is a problem with the arm platform build which is why we only have amd64 images at the moment there). See

@ingoboerner This should satisfy the original issue and I'd say we can close it. If one or more of the images do not yet work for your use cases, let's open new issues.

@cmil
Copy link
Member

cmil commented Dec 15, 2023

After merging #226, this issue should be sufficiently solved. Remaining problems can probably be solved in the context of #200.

@cmil cmil closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants