Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plugin for the window option "Synchronize panes" #138

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

JannoTjarks
Copy link
Contributor

Hi guys,

i added a plugin for your tmux theme. It's called "synchronize panes" because it gives me in the rigth status bar an info whether the window option synchronize panes (:setw synchronize panes) is on or off.

I added an info to the README.md and INSTALL.md already. Maybe you have an idea for a better infotext. At the moment the label is called "Sync" in default and the value is "on" or "off". The label is customizable for the enduser in the .tmux.conf.

I hope the code meets your requirements!
grafik

@ethancedwards8
Copy link
Member

This is cool, but why would someone need this?

@JannoTjarks
Copy link
Contributor Author

Often I use the synchronize panes option to configure cisco switches & router which need/have the same configuration (a port-channel on a vpc cluster as example) or to work on redundant linux clusters. Most time i have multiple windows open and need to know if synchronize panes is set in the current window. Other people are adding a color to the status bar: https://blog.jpalardy.com/posts/tmux-synchronized-panes/

@ethancedwards8
Copy link
Member

I see, I misunderstood before hand. I can actually see how this can be very helpful. I'll do a code review soon.

@ethancedwards8
Copy link
Member

Code LGTM, but we're going to have to clean up the commits. Otherwise, looks great and I look forward to using this feature. I would also like to get it merged in by tomorrow so we can give you credit for hacktoberfest.

@ethancedwards8 ethancedwards8 added the hacktoberfest-accepted For the hacktoberfest even label Oct 30, 2021
@JannoTjarks
Copy link
Contributor Author

That sounds great! Thank you!

@ethancedwards8
Copy link
Member

Could you squash the commits?

@JannoTjarks
Copy link
Contributor Author

I squashed the commits. Now there is only one.

@ethancedwards8
Copy link
Member

Thanks, will test.

scripts/battery.sh Outdated Show resolved Hide resolved
@JannoTjarks JannoTjarks force-pushed the synchronize-panes branch 3 times, most recently from 291ecca to 09a9694 Compare December 22, 2021 21:49
@JannoTjarks
Copy link
Contributor Author

Hi @ethancedwards8, what is the status of this pr?

@JannoTjarks
Copy link
Contributor Author

Hi @ethancedwards8, what is the current status?

@ethancedwards8
Copy link
Member

Please resolve the merge conflicts.

@JannoTjarks
Copy link
Contributor Author

Please resolve the merge conflicts.

@ethancedwards8 Done!

@magnuslarsen
Copy link

Bump :-) I would also benefit from this niche-but-amazing use case

@ethancedwards8 ethancedwards8 merged commit ef42ec6 into dracula:master Jul 12, 2023
1 check passed
@ethancedwards8
Copy link
Member

Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted For the hacktoberfest even
Development

Successfully merging this pull request may close these issues.

None yet

3 participants