Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with git gutter and FZF #82

Closed
imran-iq opened this issue May 17, 2018 · 6 comments
Closed

Issue with git gutter and FZF #82

imran-iq opened this issue May 17, 2018 · 6 comments
Labels

Comments

@imran-iq
Copy link

Related issue with screen shots: airblade/vim-gitgutter#520 (comment)

b34882be6cc is the change that caused this behaviour

Another issue caused by e4ce096 is that even though i have noshowmode set in my init.vim (for use with echodoc) leaving a fzf buffer would reset showmode to 1 thus causing echodoc to error out and increase my cmdheight to 2

Removing dracula from my plugin list fixed both issues imran-iq/dotfiles@e5db85e

@dsifford
Copy link
Member

Thanks for the report. I'll check into it.

@dsifford dsifford added the bug label May 17, 2018
@benknoble
Copy link
Member

Couple of comments based on reading the issues/code:

  1. Seems like we need a guard in after/plugin/dracula.vim to prevent loading it when the colorscheme is not dracula. However, switching to dracula afterwards will not automatically load this file... Perhaps after is not the right solution for that?
  2. For the fzf stuff, I think the fix would be to save whatever options are changed by our autocommand, and restore from that on exit.

@dsifford
Copy link
Member

I think we can leave everything in place and just source the syntax adjustments manually on colorscheme change.

We can just bind a function to call the appropriate filetype stuff to an autocmd linked to the ColorScheme event.

@dsifford
Copy link
Member

And yeah, all the files will need to have a check in place that makes sure the current colorscheme is dracula, but that's not a huge deal.

@benknoble
Copy link
Member

I opened #83 to track the after/loading problem. (Moved rest of response to that issue).

@benknoble
Copy link
Member

What if here we just used setlocal instead ?

dsifford added a commit that referenced this issue May 18, 2018
dsifford added a commit that referenced this issue May 24, 2018
* address issues #82, #83, #84

* address code review issues

* remove fzf autocmd per code review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants