Add hightlight groups for nvim-treesitter #230
Conversation
The majority of this configuration was taken from ChristianChiarulli/nvcode-color-schemes.vim#14 by [@nitishvelu](https://github.com/nitishvelu). I made a few minor tweaks based on a ruby project to make sure most of the original tokens were colored similarly.
There was a problem hiding this comment.
Thanks for the PR @DerekStride.
Looks good for the most part. Can you make sure the changes are aligned with the spec?
I added a few comments of things that stuck out at me, but I didn't comb through each group you added.
Once that's done, this should be good to merge.
There was a problem hiding this comment.
See inline suggestions.
It's important to use the builtin highlight groups wherever feasible because if someone were to switch color schemes, all of the linked dracula groups would still remain linked if the new color scheme does not re-link them. This leads to annoying bugs in some cases, particularly for those who tend to change color schemes on the fly a lot.
| hi! link TSTitle DraculaYellow | ||
| hi! link TSLiteral DraculaYellow |
There was a problem hiding this comment.
Not sure what these are specifically, but headings are purple and bold and inline code delimited with backticks is green.
Co-authored-by: Derek Sifford <dereksifford@gmail.com>
Co-authored-by: Derek Sifford <dereksifford@gmail.com>
|
LGTM. We can refine from there if needed. Thanks @DerekStride! |
What
The neovim project nvim-treesitter/nvim-treesitter ands some additional highlight groups for better syntax highlighting. I've adapted the work done by @nitishvelu in ChristianChiarulli/nvcode-color-schemes.vim#14 to support the treesitter hightlighting and would like to get it merged upstream in the main
dracula/vimplugin.Rust
Left: Highlighting with nvim-treesitter
Right: Existing highlighting
Ruby
Left: Highlighting with nvim-treesitter
Right: Existing highlighting