Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape character issue in Python #26

Closed
ajitid opened this issue Apr 30, 2017 · 3 comments
Closed

Escape character issue in Python #26

ajitid opened this issue Apr 30, 2017 · 3 comments

Comments

@ajitid
Copy link
Contributor

ajitid commented Apr 30, 2017

Check screenshot...
capture

@dsifford
Copy link
Member

@ajitid You are the master at finding inconsistencies!

Looks like the top example you gave is an issue with the textmate scope and not the theme. When typed exactly as you wrote it, the inner string is scoped as a regexp, which is why the \E and \n are highlighted as escape sequences.

I could fix that one singular issue, but by doing that I'd be breaking several other things. So the real fix would need to be made in (I believe) the python package.

Re: lines 2 and 3 -- not 100% certain, but from a google search, it appears that \E is not valid in python.

Closing this because it's out of scope.

@ajitid
Copy link
Contributor Author

ajitid commented Apr 30, 2017

I don't know much about theming, but other themes don't highlight escape characters in raw string.
I know \E is not an escape character.

I don't know whether I'm helping you or annoying you, but I like Dracula theme, and that's why so many issues 😅.

@dsifford
Copy link
Member

dsifford commented May 1, 2017

I don't know much about theming, but other themes don't highlight escape characters in raw string.
I know \E is not an escape character.

Yeah, unfortunately with the python textmate scopes, you either get highlighted escape characters or you don't; the scope is the same either way.

Additionally, \E, \Q, \B, \X, and anything in between is counted as an escaped character with the current textmate scopes, whether they are valid or not. The issue is the non-specific selectors used in the actual scope files and not the theme itself.

I don't know whether I'm helping you or annoying you, but I like Dracula theme, and that's why so many issues.

Nope, not annoying at all! Keep firing away as you see inconsistencies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants