Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dracut): link hooks directory from /lib/dracut/hooks to /var/lib/dracut/hooks #186

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

LaszloGombos
Copy link
Contributor

@LaszloGombos LaszloGombos commented Apr 16, 2024

Changes

Since systemd/systemd@ffc1ec73, /usr is mounted as read-only in the initramfs by default.

Fixes dracutdevs/dracut#2588

Minimal viable subset of #114 . No documentation change to maintain backward compatibility.

@github-actions github-actions bot added modules Issue tracker for all modules base Issues related to the base module shutdown Issues related to the shutdown module labels Apr 16, 2024
@LaszloGombos
Copy link
Contributor Author

LaszloGombos commented Apr 16, 2024

Intentionally did not change any of the tests to demonstrate that -e.g. including hooks using the old (compatible) path still works just fine - https://github.com/dracut-ng/dracut-ng/blob/main/test/TEST-01-BASIC/test.sh#L42

@LaszloGombos LaszloGombos changed the title fix(dracut): move hooks directory from /usr/lib to /var/lib fix(dracut): link hooks directory from /lib to /var/lib Apr 16, 2024
Since systemd/systemd@ffc1ec73, /usr is mounted as
read-only in the initramfs by default.

Fixes #2588
@LaszloGombos LaszloGombos changed the title fix(dracut): link hooks directory from /lib to /var/lib fix(dracut): link hooks directory from /lib/dracut/hooks to /var/lib/dracut/hooks Apr 16, 2024
@LaszloGombos
Copy link
Contributor Author

@aafeijoo-suse @lnussel - would you be able to help test this subset also in openSUSE tumbleweed with systemd from git

@LaszloGombos LaszloGombos added the compatibility kernel, firmware, systemd label Apr 16, 2024
Copy link
Collaborator

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still nags at me... But let's do it I guess.

@Conan-Kudo Conan-Kudo merged commit b185c9a into dracut-ng:main Apr 17, 2024
82 checks passed
@aafeijoo-suse
Copy link
Contributor

Ok, I have a mix of feelings between shame and anger. @LaszloGombos can you explain to me how this patch is signed using my name and company email? So, you took a portion of #114 (which btw was still under discussion), created a PR with that, and the PR was merged? Where did I give my consent to this? In another words, how legal is it?

I kindly ask you to revert this immediately. If you want to submit it, please use your name. Thank you.

@Conan-Kudo
Copy link
Collaborator

I have reverted this and stripped it from the main repository, since we haven't tagged with this yet.

Sorry for the mess, @aafeijoo-suse.

@aafeijoo-suse
Copy link
Contributor

@Conan-Kudo thank you for your prompt action to solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base Issues related to the base module compatibility kernel, firmware, systemd modules Issue tracker for all modules shutdown Issues related to the shutdown module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hookdir can't be in /usr if used for writing
3 participants