-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dracut): link hooks directory from /lib/dracut/hooks to /var/lib/dracut/hooks #186
Conversation
Intentionally did not change any of the tests to demonstrate that -e.g. including hooks using the old (compatible) path still works just fine - https://github.com/dracut-ng/dracut-ng/blob/main/test/TEST-01-BASIC/test.sh#L42 |
Since systemd/systemd@ffc1ec73, /usr is mounted as read-only in the initramfs by default. Fixes #2588
@aafeijoo-suse @lnussel - would you be able to help test this subset also in openSUSE tumbleweed with systemd from git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still nags at me... But let's do it I guess.
Ok, I have a mix of feelings between shame and anger. @LaszloGombos can you explain to me how this patch is signed using my name and company email? So, you took a portion of #114 (which btw was still under discussion), created a PR with that, and the PR was merged? Where did I give my consent to this? In another words, how legal is it? I kindly ask you to revert this immediately. If you want to submit it, please use your name. Thank you. |
I have reverted this and stripped it from the main repository, since we haven't tagged with this yet. Sorry for the mess, @aafeijoo-suse. |
@Conan-Kudo thank you for your prompt action to solve this. |
Changes
Since systemd/systemd@ffc1ec73, /usr is mounted as read-only in the initramfs by default.
Fixes dracutdevs/dracut#2588
Minimal viable subset of #114 . No documentation change to maintain backward compatibility.