Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rngd): install system service file #290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pvalena
Copy link
Contributor

@pvalena pvalena commented May 16, 2024

Note: this is dependent Fedora / RH rngd service file containing

ExecStart=/usr/sbin/rngd -f $RNGD_ARGS

Changes

Use system service file, but ship modified args to drop the user change.
There's no reason to keep a copy of rngd.service; there shouldn't be any modifications.

In case there are args stored in a separate file (Fedora and alike), it needs to be supplied too, but without the option to change the user.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@github-actions github-actions bot added modules Issue tracker for all modules rngd Issues related to the rngd module labels May 16, 2024
@pvalena pvalena marked this pull request as ready for review May 16, 2024 09:55
@LaszloGombos
Copy link
Contributor

For reference - earlier discussion on this - dracutdevs/dracut#2442

@LaszloGombos
Copy link
Contributor

LaszloGombos commented May 17, 2024

This PR in its current form breaks FULL-SYSTEMD test on Arch.

rngd.service in Arch

CC @freswa @dalto8

@freswa
Copy link

freswa commented May 17, 2024

Is it correct, that the test is only failing due to the different ENV var naming?

@LaszloGombos
Copy link
Contributor

@pvalena
Copy link
Contributor Author

pvalena commented May 23, 2024

https://bugzilla.redhat.com/show_bug.cgi?id=2181540

Yeah, that was why I created this. To not update it / ship it further in the future. Sorry, I lost the reference - but will put it into the commit msg.

as there's no reason to keep a copy; there shouldn't be any modifications.

In case there are args stored in a separate file (Fedora and alike),
it needs to be supplied too, but without the option to change the user.

This avoids shipping and maintaining the service file.

https://bugzilla.redhat.com/show_bug.cgi?id=2181540
@pvalena
Copy link
Contributor Author

pvalena commented May 29, 2024

Is it correct, that the test is only failing due to the different ENV var naming?

@freswa Yes, I think so - RNGD_OPTS vs RNGD_ARGS. I can add both into sysconfig file though, if you're against renaming the ENV.

@freswa
Copy link

freswa commented May 29, 2024

Is it correct, that the test is only failing due to the different ENV var naming?

@freswa Yes, I think so - RNGD_OPTS vs RNGD_ARGS. I can add both into sysconfig file though, if you're against renaming the ENV.

Not at all. I think we're ok renaming it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modules Issue tracker for all modules rngd Issues related to the rngd module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants