-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rngd): install system service file #290
base: main
Are you sure you want to change the base?
Conversation
For reference - earlier discussion on this - dracutdevs/dracut#2442 |
This PR in its current form breaks FULL-SYSTEMD test on Arch. |
Is it correct, that the test is only failing due to the different ENV var naming? |
b8dda4d
to
9498fd1
Compare
Yeah, that was why I created this. To not update it / ship it further in the future. Sorry, I lost the reference - but will put it into the commit msg. |
as there's no reason to keep a copy; there shouldn't be any modifications. In case there are args stored in a separate file (Fedora and alike), it needs to be supplied too, but without the option to change the user. This avoids shipping and maintaining the service file. https://bugzilla.redhat.com/show_bug.cgi?id=2181540
9498fd1
to
8b25a64
Compare
@freswa Yes, I think so - |
Not at all. I think we're ok renaming it. |
Note: this is dependent Fedora / RH rngd service file containing
ExecStart=/usr/sbin/rngd -f $RNGD_ARGS
Changes
Use system service file, but ship modified args to drop the user change.
There's no reason to keep a copy of
rngd.service
; there shouldn't be any modifications.In case there are args stored in a separate file (Fedora and alike), it needs to be supplied too, but without the option to change the user.
Checklist