Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dmsquash-live): use the overlay size with thin provisioning #61

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

dracutng
Copy link

@dracutng dracutng commented Apr 1, 2024

Using the overlay size in the device mapper table allows the filesystem in the base image to be extended at runtime if the overlay is larger than the base image (i.e. this makes resize2fs /dev/mapper/live-rw work when rd.live.overlay.thin is used).

Changes

This patch changes the upper-bound of the live-rw device when the user requests to create a thin-provisioned overlay by specifying the rd.live.overlay.thin kernel parameter. The size of the overlay (typically 32GiB, but it can be specified by the user with a kernel parameter) is used rather than the size of the base image.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Users of Fedora Linux have been reporting this bug here: https://discussion.fedoraproject.org/t/fedora-liveos-root-system-and-available-ram/82531/1

CC @gregory-lee-bartholomew

(Cherry-picked commit from dracutdevs/dracut#2604)

@Conan-Kudo
Copy link
Collaborator

This patch needs the commit message reworked.

@github-actions github-actions bot added modules Issue tracker for all modules dmsquash-live Issues related to the dmsquash-live module labels Apr 1, 2024
@dracutng dracutng changed the title with thin provisioning, use the overlay size, not the base image size fix(dmsquash-live): use the overlay size with thin provisioning Apr 1, 2024
Using the overlay size in the device mapper table allows the filesystem
in the base image to be extended if the overlay is larger than the
base image (e.g. `resize2fs /dev/mapper/live-rw`).
@Conan-Kudo Conan-Kudo merged commit 2e025eb into dracut-ng:main Apr 1, 2024
101 checks passed
@dracutng dracutng deleted the _2604 branch April 2, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dmsquash-live Issues related to the dmsquash-live module modules Issue tracker for all modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants