Skip to content

Commit

Permalink
fix(fcoe): rename rd.nofcoe to rd.fcoe
Browse files Browse the repository at this point in the history
The current name of this bool is kinda stupid. Based on the manpage
setting it to 0 turns off fcoe, which means that nofcoe=1 should mean
that it is on.

Let's just do the same thing as with rd.lvm=0, rd.luks=0,....
  • Loading branch information
lnykryn authored and johannbg committed Feb 19, 2021
1 parent 805b46c commit 6f7823b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion dracut.cmdline.7.asc
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ iscsistart -b --param node.session.timeo.replacement_timeout=30
FCoE
~~~~
**rd.nofcoe=0**::
**rd.fcoe=0**::
disable FCoE and lldpad
**fcoe=**__<edd|interface|MAC>__:__{dcb|nodcb}__:__{fabric|vn2vn}__::
Expand Down
4 changes: 2 additions & 2 deletions modules.d/95fcoe/lldpad.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash

if ! getargbool 1 rd.nofcoe ; then
info "rd.nofcoe=0: skipping lldpad activation"
if ! getargbool 1 rd.fcoe -d -n rd.nofcoe ; then
info "rd.fcoe=0: skipping lldpad activation"
return 0
fi

Expand Down
4 changes: 2 additions & 2 deletions modules.d/95fcoe/parse-fcoe.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
# fcoe=eth0:nodcb:vn2vn
# fcoe=4a:3f:4c:04:f8:d7:nodcb:fabric

if ! getargbool 1 rd.nofcoe ; then
info "rd.nofcoe=0: skipping fcoe"
if ! getargbool 1 rd.fcoe -d -n rd.nofcoe ; then
info "rd.fcoe=0: skipping fcoe"
return 0
fi

Expand Down

0 comments on commit 6f7823b

Please sign in to comment.