Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

95lunmask/parse-lunmask.sh shellcheck regression #1271

Closed
haraldh opened this issue Mar 29, 2021 · 0 comments · Fixed by #1333
Closed

95lunmask/parse-lunmask.sh shellcheck regression #1271

haraldh opened this issue Mar 29, 2021 · 0 comments · Fixed by #1333
Labels
bug Our bugs
Milestone

Comments

@haraldh
Copy link
Collaborator

haraldh commented Mar 29, 2021

parse-lunmask.sh is not bash and dash doesn't understand read -a

for lunmask_arg in $(getargs rd.lunmask); do
IFS="," read -r -a _args <<< "$lunmask_arg"
if [ -d /sys/module/scsi_mod ]; then
printf "manual" > /sys/module/scsi_mod/parameters/scan
elif [ ! -f /etc/modprobe.d/95lunmask.conf ]; then
echo "options scsi_mod scan=manual" > /etc/modprobe.d/95lunmask.conf
fi
create_udev_rule "${_args[@]}"
done

@haraldh haraldh added the bug Our bugs label Mar 29, 2021
@haraldh haraldh added this to the dracut-054 milestone Mar 29, 2021
haraldh added a commit to haraldh/dracut that referenced this issue Mar 31, 2021
`parse-lunmask.sh` is not a bash script
and dash doesn't understand `read -a`.

Revert to the initial code.

Fixes: dracutdevs#1271
haraldh added a commit that referenced this issue Mar 31, 2021
`parse-lunmask.sh` is not a bash script
and dash doesn't understand `read -a`.

Revert to the initial code.

Fixes: #1271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Our bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant