Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shellcheck regression 90multipath/multipathd-stop.sh #1275

Closed
haraldh opened this issue Mar 29, 2021 · 0 comments · Fixed by #1330
Closed

shellcheck regression 90multipath/multipathd-stop.sh #1275

haraldh opened this issue Mar 29, 2021 · 0 comments · Fixed by #1330
Labels
bug Our bugs
Milestone
dracut-054

Comments

@haraldh
Copy link
Collaborator

haraldh commented Mar 29, 2021

dracut/modules.d/90multipath/multipathd-stop.sh

Line 7 in eb0d3fb

kill "$HARD" "$pid" > /dev/null 2>&1

should be:

            kill ${HARD:+"$HARD"} "$pid" > /dev/null 2>&1

or unquoted
@haraldh haraldh added the bug Our bugs label Mar 29, 2021
@haraldh haraldh added this to the dracut-054 milestone Mar 29, 2021
haraldh added a commit to haraldh/dracut that referenced this issue Mar 31, 2021
@haraldh
fix(multipath): revise multipathd-stop
2ddfd4e 
A shellcheck regression quoted `HARD` in
```shell
    kill "$HARD" "$pid" > /dev/null 2>&1
```

which would error on an empty "HARD".

Instead of fixing this, use `pkill` instead and also add it to the
non-optional list of binaries to install, which was revised also.

Fixes: dracutdevs#1275
@haraldh haraldh mentioned this issue Mar 31, 2021
Merged
haraldh added a commit that referenced this issue Mar 31, 2021
@haraldh
fix(multipath): revise multipathd-stop
7b8c78f 
A shellcheck regression quoted `HARD` in
```shell
    kill "$HARD" "$pid" > /dev/null 2>&1
```

which would error on an empty "HARD".

Instead of fixing this, use `pkill` instead and also add it to the
non-optional list of binaries to install, which was revised also.

Fixes: #1275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Our bugs
Projects
None yet
Milestone
dracut-054
Development

Successfully merging a pull request may close this issue.

fix(multipath): revise multipathd-stop haraldh/dracut
1 participant
@haraldh