feat(mkinitrd): remove mkinitrd #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not working anyway, so nobody used it for years. If it is not used, just remove it. mkinitrd-suse.sh will be maintained by SUSE as it is SUSE specific anyway.
johannbg
approved these changes
Mar 30, 2021
danimo
approved these changes
Mar 30, 2021
lzaoral
added a commit
to lzaoral/rear
that referenced
this pull request
Jun 21, 2022
For a long time, mkinitrd was a wrapper script around dracut in Fedora and RHEL that maintained backwards compatibility with the real (but rather obsolete) mkinitrd. Dracut 054 removed the mkinitrd wrapper script [1] so now we have to execute dracut directly. Fortunately, ReaR did not use almost anything from mkinitrd's interface (with the exception of --with) so the transition is quite straightforward. Without this patch the initrd regeneration in the finalize stage of recovery fails on RHEL 9 and Fedora 33 or newer. [1] dracutdevs/dracut#1285
lzaoral
added a commit
to lzaoral/rear
that referenced
this pull request
Jun 22, 2022
For a long time, mkinitrd was a wrapper script around dracut in Fedora and RHEL that maintained backwards compatibility with the real (but rather obsolete) mkinitrd. Dracut 054 removed the mkinitrd wrapper script [1] so now we have to execute dracut directly. Fortunately, ReaR did not use almost anything from mkinitrd's interface (with the exception of --with) so the transition is quite straightforward and should not introduce any regressions because dracut is the default initrd generator since RHEL 6. Without this patch the initrd regeneration in the finalize stage of recovery fails on RHEL 9 and Fedora 33 or newer. [1] dracutdevs/dracut#1285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not working anyway, so nobody used it for years.
If it is not used, just remove it.
mkinitrd-suse.sh will be maintained by SUSE as it is SUSE specific
anyway.