Add errors and warnings when network interface does not exist #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ifcfg
johannbg
requested changes
Nov 23, 2021
There was a problem hiding this comment.
Can you change your commit message
from
Add errors and warnings when network interface does not exist
to
fix(network): add errors and warnings when network interface does not exist
can you also run shfmt -s -w modules.d/35network-legacy/ifup.sh to fix the formatting errors.
… exist End with error, or show a warning when nonexistent device is specified for network setup like `ip=10.12.8.12::10.12.255.254:255.255.0.0:xk12:eth0:off`. I've added the error only for `write-ifcfg.sh`, as I think no such setup should be written. Resolves: #1712424
Done. |
johannbg
approved these changes
Nov 24, 2021
haraldh
approved these changes
Nov 25, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End with error, or show a warning when nonexistent device is specified for network setup like
ip=10.12.8.12::10.12.255.254:255.255.0.0:xk12:eth0:off.Changes
I've added the error only for
write-ifcfg.sh, as I think no such setup should be written. For the rest I added only warnings, as I'm not sure$devis not set to something else, or it can be a non-critical error.Checklist
Fixes #1712424
Additional
I'm new to this - this is my first issue, so I'm not entirely sure how to test this. The test suite does not work for me, locally, but I'll try to create a reproducer.