dmsquash-live-root: Run checkisomd5 on correct device #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dmsquash-live
rvykydal
reviewed
Jul 26, 2022
rvykydal
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Also, you need to change your commit message from:
dmsquash-live-root: Run checkisomd5 on correct device
to something like:
fix(dmsquash-live): run checkisomd5 on correct device
See https://github.com/dracutdevs/dracut/blob/master/docs/HACKING.md#commit-messages
pvalena
suggested changes
Jul 26, 2022
bcl
force-pushed
the
dmsquash-grub2-iso
branch
2 times, most recently
from
af37a4c
to
8270bec
Compare
FGrose
reviewed
Jul 26, 2022
LaszloGombos
reviewed
Aug 6, 2022
When the new grub2 iso is written to a usb drive the disk label points to a partition that does not include the full iso image. This causes checkisomd5 to run with the wrong data and it fails. This patch adds a check that will test to see if there is a parent device that is a disk, and to run checkisomd5 on it instead of on the partition pointed to by the label. When running from an iso this will return the original /dev/disk/by-label/ path, and when running from a usb drive it will return the parent device (eg. /dev/sda). Resolves: rhbz#2107858
|
@LaszloGombos looks like one of the tests timed out. I don't think I have the power to retry, can you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the new grub2 iso is written to a usb drive the disk label points
to a partition that does not include the full iso image. This causes
checkisomd5 to run with the wrong data and it fails.
This patch adds a check that will test to see if there is a parent
device that is a disk, and to run checkisomd5 on it instead of on the
partition pointed to by the label.
When running from an iso this will return the original
/dev/disk/by-label/ path, and when running from a usb drive it will
return the parent device (eg. /dev/sda).
Resolves: rhbz#2107858
Checklist