feat(kernel-modules): driver support for macbook keyboards

[pvalena]

Discussed in: https://bugzilla.redhat.com/show_bug.cgi?id=2166209

Changes

Add kernel module -driver which is needed for keybord support on macbooks.

Checklist

• I have tested it locally
• I have reviewed and updated any documentation if relevant
• I am providing new code and test(s) for it

Notes

I will test and report soon. This patch will also land in Fedora rawhide (for testing purposes).

Credit for patch: Hans de Goede

[LaszloGombos]

Is the spi_pxa2xx_platform kernel module enough ?

What about applespi ?

See also https://bugzilla.redhat.com/show_bug.cgi?id=1769465 and https://github.com/darkmuggle/fedora-mbp-14.1/blob/patronus/files/macbook.conf

[pvalena]

Is the spi_pxa2xx_platform kernel module enough ?

What about applespi ?

See also https://bugzilla.redhat.com/show_bug.cgi?id=1769465 and https://github.com/darkmuggle/fedora-mbp-14.1/blob/patronus/files/macbook.conf

Hello, thanks for checking!

I don't know about luks / plymouth. It might have other dependencies. Users report adding this driver is sufficient for them (maybe it pulls the dependencies transitively?).

Sorry, I do not have any further insight, but I'll ask and gather feedback.

Drivers can be however added one-by-one for users and their specific cases, right?

[damaestro]

Is the spi_pxa2xx_platform kernel module enough ?

What about applespi ?

See also https://bugzilla.redhat.com/show_bug.cgi?id=1769465 and https://github.com/darkmuggle/fedora-mbp-14.1/blob/patronus/files/macbook.conf

On a fresh install of Fedora Rawhide applespi and spi_pxa2xx_platform are loaded post-install.

lsinitrd shows that applespi is already included in the initramfs for kernel-core-6.2.0-[...]

lsinitrd /boot/initramfs-6.2.0-0.rc8.20230217gitec35307e18ba.60.fc39.x86_64.img|grep applespi
-rw-r--r--   1 root     root        20060 Jan 18 19:00 usr/lib/modules/6.2.0-0.rc8.20230217gitec35307e18ba.60.fc39.x86_64/kernel/drivers/input/keyboard/applespi.ko.xz

[johannbg]

LGTM

[LaszloGombos]

lgtm